Difference in Json with ByGameId and ByGameName

Need help with your application? Ask here.
Post Reply
Cocotteseb
Posts: 4
Joined: Sat Jul 28, 2018 2:04 pm

Difference in Json with ByGameId and ByGameName

Post by Cocotteseb » Sun Dec 23, 2018 7:45 pm

Hello,

I notice a difference in the Json returned for the two functions ByGameId and ByGameName with node data :

ByGameId
include* {
boxart* {...}
platform* {
data* {
1* {...}
3* {...}

ByGameName
include* {
boxart* {...}
platform* {
1* {...}
14* {...}

You notice the "missing" data node. Thus I cannot use the same C# class for deserialization. It is not a major issue I have to create two different classes but I wonder why there is a difference ? :?

Keep up the good work!

User avatar
Zer0xFF
Posts: 253
Joined: Fri Apr 20, 2018 9:18 am

Re: Difference in Json with ByGameId and ByGameName

Post by Zer0xFF » Wed Dec 26, 2018 6:37 am

Hi,

thanks for reporting this was a stupid oversight on my behalf, but since this would introduce a breaking change, I've pushed the changes to `https://api.thegamesdb.net/v1.1/Games/ByGameName`.

Regards
Zer0xFF
Regards
Zer0xFF

Cocotteseb
Posts: 4
Joined: Sat Jul 28, 2018 2:04 pm

Re: Difference in Json with ByGameId and ByGameName

Post by Cocotteseb » Fri Dec 28, 2018 12:28 pm

Hi Zer0xFF,

Thanks for the update. I confirm it works now :)

RVDSoft
Posts: 7
Joined: Thu Jul 05, 2018 8:37 am

Re: Difference in Json with ByGameId and ByGameName

Post by RVDSoft » Thu Jan 03, 2019 2:47 pm

Will the "v1.1" endpoint stay accessible in the long term?

User avatar
Zer0xFF
Posts: 253
Joined: Fri Apr 20, 2018 9:18 am

Re: Difference in Json with ByGameId and ByGameName

Post by Zer0xFF » Thu Jan 03, 2019 5:24 pm

RVDSoft wrote:
Thu Jan 03, 2019 2:47 pm
Will the "v1.1" endpoint stay accessible in the long term?
yes, we'll probably move to /v*/ model for API iteration, and will deprecate old API as required(or as absolute breaking changes are introduced), but as it stands, the /v1.1/ endpoint will remain alive for as long as the current api endpoint are live, since they're all v1 currently.

just to clarify as well, if you're asking if /v1.1/ will be merged to current endpoint, then the answer is no, since devs are already using that endpoint and it will break their apps, so it will remain a separate revision.

I just want to add, that while we will keep old API going forward, we'd only do saw if they have minimal maintenance and performance cost.

Regards
Zer0xFF
Regards
Zer0xFF

Post Reply